Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template-typescript): add eslint-plugin-import/typescript rules #2048

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

unasuke
Copy link
Contributor

@unasuke unasuke commented Nov 22, 2020

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

It's required config in typesctipt project.
https://github.com/benmosher/eslint-plugin-import#typescript

@codecov
Copy link

codecov bot commented Nov 22, 2020

Codecov Report

Merging #2048 (ce557bd) into master (001ff24) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2048   +/-   ##
=======================================
  Coverage   72.65%   72.65%           
=======================================
  Files          74       74           
  Lines        2220     2220           
  Branches      420      420           
=======================================
  Hits         1613     1613           
  Misses        444      444           
  Partials      163      163           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 001ff24...ce557bd. Read the comment docs.

@unasuke unasuke force-pushed the eslint-plugin-import branch from d813edd to ce557bd Compare November 22, 2020 20:07
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@malept malept changed the title fix(template-typescript): enable "plugin:import/typescript" of eslint fix(template-typescript): add eslint-plugin-import/typescript rules Nov 23, 2020
@malept malept merged commit c27ca4b into electron:master Nov 23, 2020
@unasuke unasuke deleted the eslint-plugin-import branch November 23, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants