Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template/typescript-webpack): magic constant is a string & describe it #2166

Merged

Conversation

malept
Copy link
Member

@malept malept commented Feb 18, 2021

Summarize your changes:

Does what it says on the tin.

@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #2166 (738c406) into master (90f122c) will decrease coverage by 16.40%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2166       +/-   ##
===========================================
- Coverage   72.71%   56.31%   -16.41%     
===========================================
  Files          74       47       -27     
  Lines        2221     1442      -779     
  Branches      420      290      -130     
===========================================
- Hits         1615      812      -803     
- Misses        446      531       +85     
+ Partials      160       99       -61     
Impacted Files Coverage Δ
packages/api/core/src/util/upgrade-forge-config.ts 10.71% <0.00%> (-85.72%) ⬇️
packages/api/core/src/util/publish-state.ts 12.19% <0.00%> (-80.49%) ⬇️
packages/maker/dmg/src/MakerDMG.ts 38.88% <0.00%> (-61.12%) ⬇️
packages/api/core/src/util/electron-version.ts 33.33% <0.00%> (-60.32%) ⬇️
packages/maker/deb/src/MakerDeb.ts 42.10% <0.00%> (-57.90%) ⬇️
packages/maker/rpm/src/MakerRpm.ts 42.10% <0.00%> (-57.90%) ⬇️
packages/api/core/src/api/publish.ts 18.42% <0.00%> (-51.32%) ⬇️
packages/api/core/src/util/hook.ts 40.00% <0.00%> (-50.00%) ⬇️
packages/maker/wix/src/util/author-name.ts 50.00% <0.00%> (-50.00%) ⬇️
packages/maker/appx/src/util/author-name.ts 50.00% <0.00%> (-50.00%) ⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90f122c...fcf9aed. Read the comment docs.

@malept malept merged commit f15b5c7 into master Feb 18, 2021
@malept malept deleted the malept/fix/typescript-webpack/describe-magic-constant branch February 18, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant