Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-local-electron): bind methods correctly #2280

Merged
merged 1 commit into from
May 22, 2021

Conversation

malept
Copy link
Member

@malept malept commented May 22, 2021

Summarize your changes:

Fixes #2279

@codecov
Copy link

codecov bot commented May 22, 2021

Codecov Report

Merging #2280 (dde2564) into master (564a445) will increase coverage by 2.44%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2280      +/-   ##
==========================================
+ Coverage   73.14%   75.59%   +2.44%     
==========================================
  Files          74       74              
  Lines        2193     2200       +7     
  Branches      413      413              
==========================================
+ Hits         1604     1663      +59     
- Misses        418      421       +3     
+ Partials      171      116      -55     
Impacted Files Coverage Δ
...s/plugin/local-electron/src/LocalElectronPlugin.ts 100.00% <100.00%> (ø)
packages/maker/base/src/Maker.ts 75.67% <0.00%> (-2.11%) ⬇️
packages/installer/darwin/src/InstallerDarwin.ts 31.57% <0.00%> (-1.76%) ⬇️
packages/api/core/src/util/upgrade-forge-config.ts 94.73% <0.00%> (-1.70%) ⬇️
packages/api/core/src/api/init.ts 97.05% <0.00%> (+5.88%) ⬆️
packages/api/core/src/api/make.ts 88.29% <0.00%> (+6.57%) ⬆️
packages/api/core/src/util/rebuild.ts 100.00% <0.00%> (+7.14%) ⬆️
packages/api/core/src/api/install.ts 94.87% <0.00%> (+16.66%) ⬆️
packages/api/core/src/api/start.ts 87.34% <0.00%> (+20.25%) ⬆️
packages/api/core/src/api/publish.ts 92.10% <0.00%> (+22.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 564a445...dde2564. Read the comment docs.

@malept malept merged commit e60445d into master May 22, 2021
@malept malept deleted the malept/fix/plugin-local-electron/method-bindings branch May 22, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugin-local-electron, Can not read property 'enabled' of undefined
1 participant