Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-webpack): add nodeIntegration config for renderers #2330

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

malept
Copy link
Member

@malept malept commented Jun 18, 2021

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Fixes #2293.
Closes #2322.

Needs docs to be added to the Webpack plugin guide.

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #2330 (1dafbe2) into master (94b0f96) will increase coverage by 1.55%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2330      +/-   ##
==========================================
+ Coverage   74.04%   75.60%   +1.55%     
==========================================
  Files          74       74              
  Lines        2200     2201       +1     
  Branches      413      414       +1     
==========================================
+ Hits         1629     1664      +35     
+ Misses        460      421      -39     
- Partials      111      116       +5     
Impacted Files Coverage Δ
packages/plugin/webpack/src/WebpackConfig.ts 97.61% <100.00%> (+0.02%) ⬆️
packages/maker/base/src/Maker.ts 75.67% <0.00%> (+2.70%) ⬆️
packages/api/core/src/api/make.ts 88.29% <0.00%> (+3.19%) ⬆️
packages/api/core/src/api/lint.ts 69.23% <0.00%> (+3.84%) ⬆️
packages/maker/zip/src/MakerZIP.ts 100.00% <0.00%> (+7.69%) ⬆️
packages/maker/appx/src/MakerAppX.ts 57.14% <0.00%> (+17.85%) ⬆️
packages/maker/squirrel/src/MakerSquirrel.ts 77.27% <0.00%> (+40.90%) ⬆️
packages/maker/wix/src/MakerWix.ts 86.36% <0.00%> (+40.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94b0f96...1dafbe2. Read the comment docs.

@malept malept merged commit 6e0a624 into master Jun 18, 2021
@malept malept deleted the malept/gh-2293/webpack-nodeintegration branch June 18, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant