fix(maker-squirrel): use executableName for exe when available #2365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
Fixes a bug reported in Discord.
Steps to reproduce:
npx create-electron-app example-app cd example-app
Update package.json and merge the following instructions in:
Expected: Squirrel installer finds
MyExampleApp.exe
Actual: Squirrel installer tries and fails to look for
My Example App.exe
.Solution: fix the default
exe
option to checkforgeConfig.packagerConfig.executableName
first.