Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plugin-webpack): cleanup #2368

Merged
merged 3 commits into from
Jul 11, 2021
Merged

Conversation

malept
Copy link
Member

@malept malept commented Jul 11, 2021

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Follow-up from #2225:

@codecov
Copy link

codecov bot commented Jul 11, 2021

Codecov Report

Merging #2368 (5a81430) into master (84aaa8c) will decrease coverage by 0.80%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2368      +/-   ##
==========================================
- Coverage   75.57%   74.77%   -0.81%     
==========================================
  Files          74       76       +2     
  Lines        2203     2287      +84     
  Branches      416      434      +18     
==========================================
+ Hits         1665     1710      +45     
- Misses        421      472      +51     
+ Partials      117      105      -12     
Impacted Files Coverage Δ
packages/plugin/webpack/src/WebpackPlugin.ts 33.87% <0.00%> (-24.60%) ⬇️
packages/plugin/webpack/src/WebpackConfig.ts 97.61% <100.00%> (ø)
packages/utils/web-multi-logger/src/Log.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/utils/web-multi-logger/src/Logger.ts 21.05% <0.00%> (-68.43%) ⬇️
packages/utils/web-multi-logger/src/Tab.ts 20.00% <0.00%> (-60.00%) ⬇️
...es/plugin/webpack/src/util/ElectronForgeLogging.ts 13.79% <0.00%> (-48.28%) ⬇️
...lisher/electron-release-server/src/PublisherERS.ts 27.27% <0.00%> (ø)
packages/publisher/github/src/util/github.ts 100.00% <0.00%> (ø)
packages/template/base/src/determine-author.ts 100.00% <0.00%> (+17.64%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84aaa8c...5a81430. Read the comment docs.

@malept malept merged commit 597e263 into master Jul 11, 2021
@malept malept deleted the malept/webpack/webpack-5-cleanup branch July 11, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant