Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(template-base): replace exec/promisify with @malept/cross-spawn-promise #2391

Merged
merged 2 commits into from
Jul 20, 2021

Conversation

malept
Copy link
Member

@malept malept commented Jul 19, 2021

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Reduce the amount of uses of util.promisify because it's problematic in newer versions of TypeScript.

@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #2391 (fd5ecd7) into master (d5743d3) will increase coverage by 0.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2391      +/-   ##
==========================================
+ Coverage   74.59%   74.97%   +0.38%     
==========================================
  Files          77       91      +14     
  Lines        2299     2334      +35     
  Branches      436      436              
==========================================
+ Hits         1715     1750      +35     
  Misses        476      476              
  Partials      108      108              
Impacted Files Coverage Δ
packages/template/base/src/determine-author.ts 100.00% <100.00%> (ø)
packages/maker/flatpak/index.ts 100.00% <0.00%> (ø)
packages/utils/async-ora/index.ts 100.00% <0.00%> (ø)
packages/maker/appx/index.ts 100.00% <0.00%> (ø)
packages/maker/dmg/index.ts 100.00% <0.00%> (ø)
packages/plugin/base/index.ts 100.00% <0.00%> (ø)
packages/template/base/index.ts 100.00% <0.00%> (ø)
packages/maker/snap/index.ts 100.00% <0.00%> (ø)
packages/maker/rpm/index.ts 100.00% <0.00%> (ø)
packages/maker/base/index.ts 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5743d3...fd5ecd7. Read the comment docs.

@malept malept merged commit 61deea9 into master Jul 20, 2021
@malept malept deleted the refactor/template-base/remove-promisify branch July 20, 2021 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant