Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(maker-dmg): add the arch to the default dmg name #2431

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

malept
Copy link
Member

@malept malept commented Aug 9, 2021

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

As reported in Discord, publishing both arm64 and x64 DMGs are by default difficult because it's named the same despite being built for different architectures. This adds the target arch to the default DMG basename.

Comment on lines +10 to +13
"scripts": {
"test": "yarn test:base test/**/*_spec.ts",
"test:base": "cross-env TS_NODE_FILES=1 mocha --config ../../../.mocharc.js"
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't directly related. I just needed an easy way to run just the DMG maker's tests.

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #2431 (f61c44c) into master (4a992b7) will decrease coverage by 2.34%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2431      +/-   ##
==========================================
- Coverage   75.08%   72.73%   -2.35%     
==========================================
  Files          91       91              
  Lines        2348     2344       -4     
  Branches      440      440              
==========================================
- Hits         1763     1705      -58     
+ Misses        476      473       -3     
- Partials      109      166      +57     
Impacted Files Coverage Δ
packages/maker/dmg/src/MakerDMG.ts 100.00% <100.00%> (ø)
packages/api/core/src/api/publish.ts 69.73% <0.00%> (-22.37%) ⬇️
packages/api/core/src/api/start.ts 65.43% <0.00%> (-22.23%) ⬇️
packages/api/core/src/api/install.ts 78.20% <0.00%> (-16.67%) ⬇️
packages/api/core/src/util/rebuild.ts 92.85% <0.00%> (-7.15%) ⬇️
packages/api/core/src/api/make.ts 81.72% <0.00%> (-6.58%) ⬇️
packages/api/core/src/api/init.ts 92.68% <0.00%> (-4.88%) ⬇️
packages/api/core/src/util/upgrade-forge-config.ts 96.42% <0.00%> (+1.69%) ⬆️
packages/installer/darwin/src/InstallerDarwin.ts 33.33% <0.00%> (+1.75%) ⬆️
packages/maker/base/src/Maker.ts 77.77% <0.00%> (+2.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a992b7...f61c44c. Read the comment docs.

@malept malept merged commit 0c65f17 into master Aug 9, 2021
@malept malept deleted the fix/maker-dmg/arch-in-filename branch August 9, 2021 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant