Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-webpack): validate that the correct entry point is used #2522

Merged
merged 2 commits into from
Sep 12, 2021

Conversation

malept
Copy link
Member

@malept malept commented Sep 12, 2021

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Addresses #2519

Basically, we can do this because afterCopy hooks are executed before the entry point validation in Electron Packager.

@codecov
Copy link

codecov bot commented Sep 12, 2021

Codecov Report

Merging #2522 (c39429d) into master (0deb74b) will increase coverage by 2.42%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2522      +/-   ##
==========================================
+ Coverage   72.71%   75.13%   +2.42%     
==========================================
  Files          91       91              
  Lines        2349     2353       +4     
  Branches      429      430       +1     
==========================================
+ Hits         1708     1768      +60     
+ Misses        471      470       -1     
+ Partials      170      115      -55     
Impacted Files Coverage Δ
packages/plugin/webpack/src/WebpackPlugin.ts 37.30% <100.00%> (+0.65%) ⬆️
packages/api/core/src/util/parse-archs.ts 83.33% <0.00%> (+3.33%) ⬆️
packages/api/core/src/api/init.ts 97.22% <0.00%> (+5.55%) ⬆️
packages/api/core/src/util/rebuild.ts 100.00% <0.00%> (+5.55%) ⬆️
packages/api/core/src/api/make.ts 88.77% <0.00%> (+8.16%) ⬆️
packages/api/core/src/api/install.ts 92.10% <0.00%> (+14.47%) ⬆️
packages/api/core/src/api/publish.ts 90.90% <0.00%> (+21.17%) ⬆️
packages/api/core/src/api/start.ts 87.65% <0.00%> (+22.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0deb74b...c39429d. Read the comment docs.

@malept malept merged commit 3de904b into master Sep 12, 2021
@malept malept deleted the malept/fix/plugin-webpack/validate-main-entry-point branch September 12, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant