Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-webpack): rebuild native modules before packaging #2584

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

malept
Copy link
Member

@malept malept commented Oct 18, 2021

Summarize your changes:

Fixes #1072.

Also adds package and arch to the prePackage hook.

@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #2584 (b55a5c4) into master (f0f96c6) will increase coverage by 0.02%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2584      +/-   ##
==========================================
+ Coverage   65.80%   65.82%   +0.02%     
==========================================
  Files          77       77              
  Lines        2737     2742       +5     
  Branches      679      679              
==========================================
+ Hits         1801     1805       +4     
+ Misses        808      806       -2     
- Partials      128      131       +3     
Impacted Files Coverage Δ
packages/plugin/webpack/src/WebpackPlugin.ts 37.43% <33.33%> (+0.13%) ⬆️
packages/api/core/src/api/package.ts 58.62% <100.00%> (ø)
packages/api/core/src/util/index.ts 100.00% <100.00%> (ø)
packages/api/core/src/api/import.ts 48.12% <0.00%> (ø)
packages/api/core/src/util/plugin-interface.ts 28.07% <0.00%> (ø)
packages/installer/darwin/src/InstallerDarwin.ts 35.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0f96c6...b55a5c4. Read the comment docs.

@malept malept merged commit 21310bb into master Oct 18, 2021
@malept malept deleted the fix/plugin-webpack/ensure-rebuilt-native-modules branch October 18, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native modules were not rebuilt during package when webpack template is used
1 participant