Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): re-add shebang to electron-forge binary #2671

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

malept
Copy link
Member

@malept malept commented Jan 10, 2022

Summarize your changes:

Fixes #2670 and the eslint(-plugin-node) rule that caused it.

See also: https://github.com/mysticatea/eslint-plugin-node/blob/v11.1.0/docs/rules/shebang.md

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #2671 (c890075) into master (c5490b6) will decrease coverage by 1.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2671      +/-   ##
==========================================
- Coverage   65.76%   64.12%   -1.65%     
==========================================
  Files          77       77              
  Lines        2737     2606     -131     
  Branches      679      583      -96     
==========================================
- Hits         1800     1671     -129     
+ Misses        804      752      -52     
- Partials      133      183      +50     
Impacted Files Coverage Δ
packages/api/cli/src/electron-forge.ts 58.06% <ø> (ø)
packages/api/core/src/api/start.ts 48.88% <0.00%> (-25.58%) ⬇️
packages/plugin/base/src/Plugin.ts 62.50% <0.00%> (-25.00%) ⬇️
packages/installer/exe/src/InstallerExe.ts 50.00% <0.00%> (-25.00%) ⬇️
packages/api/core/src/api/publish.ts 45.26% <0.00%> (-23.67%) ⬇️
packages/api/core/src/api/install.ts 57.60% <0.00%> (-11.33%) ⬇️
packages/installer/dmg/src/util/hdiutil.ts 42.30% <0.00%> (-9.55%) ⬇️
packages/api/core/src/api/index.ts 48.83% <0.00%> (-8.95%) ⬇️
packages/installer/base/src/Installer.ts 50.00% <0.00%> (-7.15%) ⬇️
packages/api/core/src/util/yarn-or-npm.ts 88.23% <0.00%> (-6.21%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5490b6...c890075. Read the comment docs.

@malept malept merged commit 1ca418e into master Jan 10, 2022
@malept malept deleted the malept/fix/forge-shebang branch January 10, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cli - latest beta 62 error
1 participant