Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(template): add a default preload script #2722

Merged
merged 6 commits into from
Feb 13, 2022

Conversation

malept
Copy link
Member

@malept malept commented Feb 11, 2022

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Adds a preload script to every template. This is particularly useful for the Webpack templates, as it's not particularly obvious how to add a preload script with the magic constants (nor is it very easy to document).

@malept malept force-pushed the malept/feat/template/add-default-preload-script branch from e34145f to 8076cd9 Compare February 11, 2022 19:53
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #2722 (08d998b) into master (ba75c0b) will decrease coverage by 0.37%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2722      +/-   ##
==========================================
- Coverage   64.09%   63.71%   -0.38%     
==========================================
  Files          77       77              
  Lines        2607     2748     +141     
  Branches      584      682      +98     
==========================================
+ Hits         1671     1751      +80     
- Misses        753      813      +60     
- Partials      183      184       +1     
Impacted Files Coverage Δ
packages/template/base/src/BaseTemplate.ts 87.09% <100.00%> (+4.95%) ⬆️
...ypescript-webpack/src/TypeScriptWebpackTemplate.ts 100.00% <100.00%> (ø)
...ages/template/typescript/src/TypeScriptTemplate.ts 100.00% <100.00%> (ø)
packages/template/webpack/src/WebpackTemplate.ts 100.00% <100.00%> (ø)
packages/api/core/src/api/init-scripts/init-git.ts 70.58% <0.00%> (-15.13%) ⬇️
packages/maker/base/src/Maker.ts 56.14% <0.00%> (-7.13%) ⬇️
packages/utils/async-ora/src/ora.ts 54.05% <0.00%> (-6.56%) ⬇️
packages/api/core/src/api/make.ts 58.82% <0.00%> (-5.94%) ⬇️
...ges/api/core/src/api/init-scripts/find-template.ts 74.07% <0.00%> (-5.93%) ⬇️
packages/utils/async-ora/src/ora-handler.ts 71.11% <0.00%> (-5.82%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba75c0b...08d998b. Read the comment docs.

@malept malept force-pushed the malept/feat/template/add-default-preload-script branch from 6226ab1 to 27b2ec9 Compare February 12, 2022 03:47
@malept malept force-pushed the malept/feat/template/add-default-preload-script branch from 27b2ec9 to 08d998b Compare February 12, 2022 23:19
@malept malept marked this pull request as ready for review February 13, 2022 04:09
@malept malept merged commit 636e2c5 into master Feb 13, 2022
@malept malept deleted the malept/feat/template/add-default-preload-script branch February 13, 2022 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant