-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing exports from packages #2920
Conversation
…into clavin/fix-docs-deploy
Co-authored-by: Calvin <clavin@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment explaining why it's being exported? Otherwise looks fine.
Codecov Report
@@ Coverage Diff @@
## master #2920 +/- ##
==========================================
- Coverage 71.82% 71.43% -0.39%
==========================================
Files 79 79
Lines 2385 2412 +27
Branches 449 450 +1
==========================================
+ Hits 1713 1723 +10
- Misses 450 466 +16
- Partials 222 223 +1
Continue to review full report at Codecov.
|
b38a007
to
d58ed56
Compare
Summarize your changes:
Exports various interfaces from packages who were missing them. This causes docs to be generated for those symbols as well.
This also adds a plugin so default exports aren't just named
default
😬 (although, there is no indicator that they are the default export either)