-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove preload.js from TypeScript templates #2938
feat: remove preload.js from TypeScript templates #2938
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2938 +/- ##
==========================================
+ Coverage 71.32% 71.33% +0.01%
==========================================
Files 79 79
Lines 2413 2414 +1
Branches 452 452
==========================================
+ Hits 1721 1722 +1
Misses 469 469
Partials 223 223
Continue to review full report at Codecov.
|
Some of this seems to be implemented in #2936 but the tests are a great touch. |
Ah cool I saw an earlier iteration of that PR that didn't have the removal of |
…om-typescript-templates
Turns out #2936 only fixed |
Summarize your changes:
When
preload
was added to the Forge templates, the TypeScript templates actually ended up with both apreload.js
and apreload.ts
because the base template addspreload.js
and the TypeScript template adds apreload.ts
. This PR modifies the TS templates to remove thepreload.js
just like it already removes theindex.js
.I also modified the template tests to verify that no js files end up in the
src/
folder after the TypeScript templates are applied. That way if any other new files are added in the future, the tests will automatically verify that only the TypeScript versions are applied.