Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove install command #2958

Merged
merged 4 commits into from
Oct 13, 2022
Merged

chore: remove install command #2958

merged 4 commits into from
Oct 13, 2022

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Oct 13, 2022

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

This is a relic of the initial Forge implementation that we don't really use and is confusingly named (installer vs maker).

Associated docs change: https://app.gitbook.com/o/-LBKDRmeoAGTb1M5X51f/s/-LBKK1y7h_XWAtuRJG9X-4037718589/~/diff/~/changes/XT5dTLQQ9jPv9m1aByBB/

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #2958 (2c9874f) into main (827c3ea) will increase coverage by 2.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2958      +/-   ##
==========================================
+ Coverage   71.07%   73.46%   +2.39%     
==========================================
  Files          78       67      -11     
  Lines        2392     2178     -214     
  Branches      452      427      -25     
==========================================
- Hits         1700     1600     -100     
+ Misses        469      370      -99     
+ Partials      223      208      -15     
Impacted Files Coverage Δ
packages/api/core/src/api/index.ts 64.51% <ø> (+4.51%) ⬆️
packages/maker/base/src/Maker.ts 69.69% <0.00%> (ø)
packages/plugin/base/src/Plugin.ts 57.14% <0.00%> (ø)
packages/publisher/base/src/Publisher.ts 62.50% <0.00%> (ø)
packages/api/core/src/util/download-to-file.ts
packages/maker/pkg/src/MakerPKG.ts 93.33% <0.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 827c3ea...2c9874f. Read the comment docs.

@erickzhao erickzhao marked this pull request as ready for review October 13, 2022 01:22
@erickzhao erickzhao requested a review from a team October 13, 2022 01:23
@georgexu99 georgexu99 self-requested a review October 13, 2022 17:38
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the zip file be deleted?

@erickzhao
Copy link
Member Author

Shouldn't the zip file be deleted?

@malept which zip file are you referring to?

@erickzhao erickzhao requested a review from malept October 13, 2022 20:21
@malept
Copy link
Member

malept commented Oct 13, 2022

Shouldn't the zip file be deleted?

which zip file are you referring to?

packages/api/core/test/fixture/app-with-scoped-name/out/make/zip/linux/x64/@scope-package-linux-x64-1.0.0.zip

At the very least, it's weird that it's changed size

@erickzhao
Copy link
Member Author

That test fixture is used for the Make specs. I've reverted the diff 2c9874f

@erickzhao erickzhao merged commit 6b215b0 into main Oct 13, 2022
@erickzhao erickzhao deleted the uninstall branch October 13, 2022 21:21
@malept
Copy link
Member

malept commented Oct 13, 2022

Please remove references to this subcommand in electronforge.io too 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants