-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove install
command
#2958
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2958 +/- ##
==========================================
+ Coverage 71.07% 73.46% +2.39%
==========================================
Files 78 67 -11
Lines 2392 2178 -214
Branches 452 427 -25
==========================================
- Hits 1700 1600 -100
+ Misses 469 370 -99
+ Partials 223 208 -15
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the zip file be deleted?
@malept which zip file are you referring to? |
At the very least, it's weird that it's changed size |
That test fixture is used for the Make specs. I've reverted the diff 2c9874f |
Please remove references to this subcommand in |
Summarize your changes:
This is a relic of the initial Forge implementation that we don't really use and is confusingly named (installer vs maker).
Associated docs change: https://app.gitbook.com/o/-LBKDRmeoAGTb1M5X51f/s/-LBKK1y7h_XWAtuRJG9X-4037718589/~/diff/~/changes/XT5dTLQQ9jPv9m1aByBB/