-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: improve forge configuration DX #2963
Conversation
Couple of breaking changes to improve DX * Plugins now follow the same syntax as makers/publishers * Better type safety of the core make/publish APIs * Renamed electronRebuildConfig to rebuildConfig * Fixed types for packagerConfig and rebuildConfig to appropriately Omit certain forge provided keys
Codecov Report
@@ Coverage Diff @@
## main #2963 +/- ##
==========================================
- Coverage 73.46% 73.44% -0.03%
==========================================
Files 67 67
Lines 2178 2180 +2
Branches 427 426 -1
==========================================
+ Hits 1600 1601 +1
- Misses 370 371 +1
Partials 208 208
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's avoid merging this until Gitbook docs are ready
this reworks all the plugin docs and changes |
Couple of breaking changes to improve DX
With better types we can do some work to allow
forge.config.ts
and a completely type-safe config 🪄