Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete lint command #2964

Merged
merged 2 commits into from
Oct 13, 2022
Merged

chore: delete lint command #2964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e39ff44
chore: delete `lint` command
erickzhao Oct 13, 2022
d409466
lint with testUtils
erickzhao Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions packages/api/cli/src/electron-forge-lint.ts
View file
Open in desktop

This file was deleted.

26 changes: 1 addition & 25 deletions packages/api/core/src/api/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { ElectronProcess, ForgeMakeResult } from '@electron-forge/shared-types';

import _import, { ImportOptions } from './import';
import init, { InitOptions } from './init';
import lint, { LintOptions } from './lint';
import make, { MakeOptions } from './make';
import _package, { PackageOptions } from './package';
import publish, { PublishOptions } from './publish';
Expand All @@ -28,16 +27,6 @@ export class ForgeAPI {
return init(opts);
}

/**
* Lint a local Electron application.
*
* The promise will be rejected with the stdout+stderr of the linting process
* if linting fails or will be resolved if it succeeds.
*/
lint(opts: LintOptions): Promise<void> {
return lint(opts);
}

/**
* Make distributables for an Electron application
*/
Expand Down Expand Up @@ -72,17 +61,4 @@ export class ForgeAPI {
const api = new ForgeAPI();
const utils = new ForgeUtils();

export {
ForgeMakeResult,
ElectronProcess,
ForgeUtils,
ImportOptions,
InitOptions,
LintOptions,
MakeOptions,
PackageOptions,
PublishOptions,
StartOptions,
api,
utils,
};
export { ForgeMakeResult, ElectronProcess, ForgeUtils, ImportOptions, InitOptions, MakeOptions, PackageOptions, PublishOptions, StartOptions, api, utils };
44 changes: 0 additions & 44 deletions packages/api/core/src/api/lint.ts
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions packages/api/core/test/slow/api_spec_slow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { createDefaultCertificate } from '@electron-forge/maker-appx';
import { ensureTestDirIsNonexistent, expectProjectPathExists } from '@electron-forge/test-utils';
import { ensureTestDirIsNonexistent, expectLintToPass, expectProjectPathExists } from '@electron-forge/test-utils';
import { execSync } from 'child_process';
import { expect } from 'chai';
import { ForgeConfig, IForgeResolvableMaker } from '@electron-forge/shared-types';
Expand Down Expand Up @@ -78,7 +78,7 @@ for (const nodeInstaller of ['npm', 'yarn']) {
});

describe('lint', () => {
erickzhao marked this conversation as resolved.
Show resolved Hide resolved
it('should initially pass the linting process', () => forge.lint({ dir }));
it('should initially pass the linting process', () => expectLintToPass(dir));
});

after(() => fs.remove(dir));
Expand Down Expand Up @@ -116,7 +116,7 @@ for (const nodeInstaller of ['npm', 'yarn']) {
});

describe('lint', () => {
it('should initially pass the linting process', () => forge.lint({ dir }));
it('should initially pass the linting process', () => expectLintToPass(dir));
});

after(async () => {
Expand Down