Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): only load modules if package has entry point #2981

Merged
merged 2 commits into from
Oct 21, 2022

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Oct 20, 2022

Two small fixes:

  • Better type for package.json in our utility code
  • Doesn't attempt to run TypeDoc for a package if it doesn't have a main entry. Removes a warning message Warning: Could not determine the entry point for "/Users/erick.zhao/Developer/electron/forge/packages/api/cli/package.json". Package will be ignored.

@erickzhao erickzhao requested a review from a team October 20, 2022 22:08
tools/gen-docs.ts Outdated Show resolved Hide resolved
Co-authored-by: Samuel Attard <sattard@salesforce.com>
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #2981 (e669357) into main (a8b9dfc) will decrease coverage by 0.41%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2981      +/-   ##
==========================================
- Coverage   73.78%   73.36%   -0.42%     
==========================================
  Files          66       66              
  Lines        2144     2144              
  Branches      423      423              
==========================================
- Hits         1582     1573       -9     
  Misses        359      359              
- Partials      203      212       +9     
Impacted Files Coverage Δ
packages/maker/zip/src/MakerZIP.ts 90.90% <0.00%> (-9.10%) ⬇️
packages/api/core/src/api/make.ts 73.26% <0.00%> (-5.95%) ⬇️
packages/api/cli/src/util/check-system.ts 68.29% <0.00%> (-2.44%) ⬇️
packages/maker/appx/src/MakerAppX.ts 58.62% <0.00%> (-1.73%) ⬇️
packages/maker/deb/src/MakerDeb.ts 90.90% <0.00%> (ø)
packages/maker/rpm/src/MakerRpm.ts 90.90% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8b9dfc...e669357. Read the comment docs.

@erickzhao erickzhao requested a review from a team October 20, 2022 23:41
@erickzhao erickzhao merged commit bb29cd5 into main Oct 21, 2022
@erickzhao erickzhao deleted the docs/entry-point branch October 21, 2022 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants