-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move create-electron-app into forge #2988
Conversation
b022a50
to
a1d1459
Compare
Codecov Report
@@ Coverage Diff @@
## main #2988 +/- ##
=======================================
Coverage 73.80% 73.80%
=======================================
Files 67 67
Lines 2168 2168
Branches 436 436
=======================================
Hits 1600 1600
Misses 361 361
Partials 207 207 Continue to review full report at Codecov.
|
a1d1459
to
359d616
Compare
359d616
to
7b2c07a
Compare
77274e0
to
1002b31
Compare
44b8c0a
to
159a9f2
Compare
a478edd
to
4b35ffe
Compare
I'm fairly certain this is a bug in Bolt's Windows symlinking, and this method specifically is where I think we're experiencing the problem: https://github.com/boltpkg/bolt/blob/a922d937c8054dea4c4e1d4f8755583187cdd9ed/src/utils/fs.js#L59 The new package works as expected on Mac and Linux; it's only failing on Windows, but it's failing both in CI and when I run In our case, Not 100% sure how to get around this yet, but I think this is the only blocker for this PR. |
7bea467
to
a58d533
Compare
e5e3e36
to
181c8c3
Compare
Don't merge, please, want to clean this up a bit now that it's working |
d05eb38
to
8770d7b
Compare
I think the |
a911426
to
e84773f
Compare
e84773f
to
af016b6
Compare
Co-authored-by: Samuel Attard <sam@electronjs.org>
This PR moves create-electron-app into Forge's monorepo: