-
-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: prefer forge.config.js over package.json config #2991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2991 +/- ##
==========================================
+ Coverage 73.80% 73.94% +0.14%
==========================================
Files 67 68 +1
Lines 2168 2180 +12
Branches 436 434 -2
==========================================
+ Hits 1600 1612 +12
- Misses 361 362 +1
+ Partials 207 206 -1
Continue to review full report at Codecov.
|
packages/template/typescript-webpack/src/TypeScriptWebpackTemplate.ts
Outdated
Show resolved
Hide resolved
erickzhao
force-pushed
the
feat/prefer-forge-config
branch
from
October 26, 2022 21:56
05c423b
to
fac496f
Compare
This change affects the `init` and `import` commands.
erickzhao
force-pushed
the
feat/prefer-forge-config
branch
from
October 27, 2022 18:41
e224da8
to
6a29f0b
Compare
georgexu99
approved these changes
Oct 27, 2022
This was referenced Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
This change affects the
init
andimport
commands. It changes these commands to create aforge.config.js
rather than creatingconfig.forge
in your package.json.This is considered a breaking change for any third-party templates because the base template no longer sets up a
config.forge
object, and any template-specific mutations to the Forge config should instead be performed on theforge.config.js
file.Ref #2973