fix(all): disallow throwing literals (@typescript-eslint/no-throw-literal)

[erickzhao]

Better linting

This PR adds the @typescript-eslint/no-throw-literal ESLint rule, which removes the ability to throw non-Error errors.

throw 'msg'; // ❌ this will be flagged

throw {
  message: 'msg', // ❌ this will also be flagged
}

throw new Error('msg'); // ✅ this is good

Slight changes to tsconfig generation

In Forge, we generate each tsconfig.json per-package in a postinstall script. This means there is no global tsconfig.json for the project (aside from a tsconfig.test.json that we use for tests.)

However, since the @typescript-eslint/no-throw-literal rule requires a config to be specified in parserOptions.project, I moved the base TSConfig JavaScript object that we use to generate each package's TSConfig into its own tsconfig.base.json file in the project's root folder.

No more [object Object] errors

Ref #3084

We used to throw a non-standard error object in the core Make API, which ended up logging a [object Object] error in the CLI. This is fixed by following the new lint rule.

Testing

You can test this case easily on macOS by attempting to build the Squirrel.Windows without mono installed. As you can see, this PR adds a lot more clarity to the exact error message.

Before:

An unhandled rejection has occurred inside Forge:
[object Object]

Electron Forge was terminated. Location:

After:

An unhandled rejection has occurred inside Forge:
Error: spawn mono ENOENT
at ChildProcess._handle.onexit (node:internal/child_process:283:19)
    at onErrorNT (node:internal/child_process:476:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)

[malept]

Can we add tests?😅

[malept]

I mostly ask because this seems like a regression...

[erickzhao]

@malept You're right. If I'm reading the code correctly, it seems like it regressed way back in #2520, where we added the .toString() call.

I'm guessing the spike in reports is because we have a larger active userbase now that we've brought Forge under the Electron umbrella.

I can add a simple set of tests for this utility function!

[erickzhao]

This was just an unnecessary log line

[erickzhao]

typo fix

[erickzhao]

@malept After some consideration, enabling a lint rule to make sure all errors get thrown properly is better for code quality in the future.

The regression itself was caused by us doing bad stuff with errors rather than the .toString() call in terminate.ts itself.

[malept]

Sounds good to me