Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: maker-squirrel does not support macOS #3348

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

dsanders11
Copy link
Member

Summarize your changes:

Doesn't work on macOS so let's not lead folks astray.

@dsanders11 dsanders11 requested a review from a team as a code owner September 13, 2023 02:10
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this changed recently or was it always true? https://www.electronforge.io/config/makers/squirrel.windows would also need to be updated in accordance as well.

@dsanders11
Copy link
Member Author

It's been the case for several years now, see Squirrel/Squirrel.Windows#1605 and this comment from @~MarshallOfSound.

@erickzhao erickzhao merged commit 3cc261a into main Sep 15, 2023
4 checks passed
@erickzhao erickzhao deleted the docs-maker-squirrel-macos branch September 15, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants