Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template-webpack-typescript): use fork-ts-checker-webpack-plugin in main webpack config #3391

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

NoahAndrews
Copy link
Contributor

@NoahAndrews NoahAndrews commented Oct 27, 2023

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

This PR modifies the the webpack-typescript template to enable type-checking in the main webpack config, rather than just the renderer's webpack config. Without this change, Typescript compile errors in both the renderer and main process Typescript files did not appear to get printed anywhere at all. @MarshallOfSound did you verify that type-checking worked in the original version of the typescript-webpack template?

With this change, Typescript errors in either the renderer or main process source code get printed to the console that npm start is launched from.

@NoahAndrews NoahAndrews requested a review from a team as a code owner October 27, 2023 18:11
@erickzhao erickzhao changed the title feat: Use fork-ts-checker-webpack-plugin in main webpack config fix(template-webpack-typescript): use fork-ts-checker-webpack-plugin in main webpack config Oct 27, 2023
@erickzhao erickzhao merged commit f7a55f4 into electron:main Nov 15, 2023
11 checks passed
@NoahAndrews NoahAndrews deleted the patch-2 branch November 16, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants