Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): packageJSON won't be found when programmatic usage instead of CLI #3455

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

ianho
Copy link
Contributor

@ianho ianho commented Jan 2, 2024

If use programmatic usage instead of CLI, the 'package.json' wont be found in this function

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

If use programmatic usage instead of CLI, the 'package.json' wont be found in this function
@ianho ianho requested a review from a team as a code owner January 2, 2024 03:16
@ianho ianho closed this Jan 2, 2024
@ianho ianho changed the title Update resolve-dir.ts fix: packageJSON won't be found when programmatic usage instead of CLI Jan 2, 2024
@ianho ianho reopened this Jan 2, 2024
@ianho ianho closed this Jan 4, 2024
@ianho ianho reopened this Jan 4, 2024
@ianho
Copy link
Contributor Author

ianho commented Jan 5, 2024

I think this change wont make ci failed
But how can I rerun it?

@dsanders11
Copy link
Member

@ianho, I re-ran the failing CI and it's green now.

@erickzhao erickzhao changed the title fix: packageJSON won't be found when programmatic usage instead of CLI fix(core): packageJSON won't be found when programmatic usage instead of CLI Jan 19, 2024
@erickzhao erickzhao merged commit 2fe0f5d into electron:main Jan 19, 2024
9 of 10 checks passed
@erickzhao
Copy link
Member

Thanks for this!

Brooooooklyn referenced this pull request in toeverything/AFFiNE Feb 23, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@electron-forge/maker-base](https://github.com/electron/forge) | [`7.2.0` -> `7.3.0`](https://renovatebot.com/diffs/npm/@electron-forge%2fmaker-base/7.2.0/7.3.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@electron-forge%2fmaker-base/7.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@electron-forge%2fmaker-base/7.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@electron-forge%2fmaker-base/7.2.0/7.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@electron-forge%2fmaker-base/7.2.0/7.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [@napi-rs/cli](https://github.com/napi-rs/napi-rs) | [`3.0.0-alpha.40` -> `3.0.0-alpha.41`](https://renovatebot.com/diffs/npm/@napi-rs%2fcli/3.0.0-alpha.40/3.0.0-alpha.41) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@napi-rs%2fcli/3.0.0-alpha.41?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@napi-rs%2fcli/3.0.0-alpha.41?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@napi-rs%2fcli/3.0.0-alpha.40/3.0.0-alpha.41?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@napi-rs%2fcli/3.0.0-alpha.40/3.0.0-alpha.41?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>electron/forge (@&#8203;electron-forge/maker-base)</summary>

### [`v7.3.0`](https://github.com/electron/forge/releases/tag/v7.3.0)

[Compare Source](https://github.com/electron/forge/compare/v7.2.0...v7.3.0)

##### What's Changed

##### Features

-   feat(plugin-vite): upgrade to vite@5 by [@&#8203;caoxiemeihao](https://github.com/caoxiemeihao) in [https://github.com/electron/forge/pull/3468](https://github.com/electron/forge/pull/3468)
-   feat: allow a custom out dir from forge config by [@&#8203;lutzroeder](https://github.com/lutzroeder) in [https://github.com/electron/forge/pull/3458](https://github.com/electron/forge/pull/3458)
-   feat(template-vite): patch types by [@&#8203;caoxiemeihao](https://github.com/caoxiemeihao) in [https://github.com/electron/forge/pull/3494](https://github.com/electron/forge/pull/3494)
-   feat: adds default fuses to templates by [@&#8203;yangannyx](https://github.com/yangannyx) in [https://github.com/electron/forge/pull/3480](https://github.com/electron/forge/pull/3480)
-   feat(publisher-github): option to automatically generate release notes by [@&#8203;dsanders11](https://github.com/dsanders11) in [https://github.com/electron/forge/pull/3484](https://github.com/electron/forge/pull/3484)

##### Fixes

-   fix(electron-release-publisher): change api/version endpoint in PublisherERS to use versions/sorted by [@&#8203;kgallagher52](https://github.com/kgallagher52) in [https://github.com/electron/forge/pull/3431](https://github.com/electron/forge/pull/3431)
-   fix(core): packageJSON won't be found when programmatic usage instead of CLI by [@&#8203;ianho](https://github.com/ianho) in [https://github.com/electron/forge/pull/3455](https://github.com/electron/forge/pull/3455)
-   fix: actually depend on preceeding groups by [@&#8203;MarshallOfSound](https://github.com/MarshallOfSound) in [https://github.com/electron/forge/pull/3438](https://github.com/electron/forge/pull/3438)
-   fix: normalize windows version with build part correctly by [@&#8203;rickymohk](https://github.com/rickymohk) in [https://github.com/electron/forge/pull/3461](https://github.com/electron/forge/pull/3461)
-   fix: .vscode settings.json changes on open by [@&#8203;lutzroeder](https://github.com/lutzroeder) in [https://github.com/electron/forge/pull/3460](https://github.com/electron/forge/pull/3460)
-   fix(plugin-vite): package volume size to large by [@&#8203;caoxiemeihao](https://github.com/caoxiemeihao) in [https://github.com/electron/forge/pull/3336](https://github.com/electron/forge/pull/3336)

##### Performance

-   refactor: only run webpack once for multi-arch packages by [@&#8203;MarshallOfSound](https://github.com/MarshallOfSound) in [https://github.com/electron/forge/pull/3437](https://github.com/electron/forge/pull/3437)

##### Other Changes

-   chore: update Packager by [@&#8203;erikian](https://github.com/erikian) in [https://github.com/electron/forge/pull/3419](https://github.com/electron/forge/pull/3419)
-   chore: bump electronjs/node to 2.2.0 (main) by [@&#8203;electron-roller](https://github.com/electron-roller) in [https://github.com/electron/forge/pull/3469](https://github.com/electron/forge/pull/3469)
-   chore(plugins/electronegativity): correct some config types  by [@&#8203;Dogdriip](https://github.com/Dogdriip) in [https://github.com/electron/forge/pull/3482](https://github.com/electron/forge/pull/3482)
-   chore: use Dependabot to update GitHub Actions deps by [@&#8203;dsanders11](https://github.com/dsanders11) in [https://github.com/electron/forge/pull/3487](https://github.com/electron/forge/pull/3487)
-   chore: bump electronjs/node to 2.2.1 (main) by [@&#8203;electron-roller](https://github.com/electron-roller) in [https://github.com/electron/forge/pull/3496](https://github.com/electron/forge/pull/3496)

##### New Contributors

-   [@&#8203;kgallagher52](https://github.com/kgallagher52) made their first contribution in [https://github.com/electron/forge/pull/3431](https://github.com/electron/forge/pull/3431)
-   [@&#8203;rickymohk](https://github.com/rickymohk) made their first contribution in [https://github.com/electron/forge/pull/3461](https://github.com/electron/forge/pull/3461)
-   [@&#8203;lutzroeder](https://github.com/lutzroeder) made their first contribution in [https://github.com/electron/forge/pull/3460](https://github.com/electron/forge/pull/3460)
-   [@&#8203;ianho](https://github.com/ianho) made their first contribution in [https://github.com/electron/forge/pull/3455](https://github.com/electron/forge/pull/3455)
-   [@&#8203;yangannyx](https://github.com/yangannyx) made their first contribution in [https://github.com/electron/forge/pull/3480](https://github.com/electron/forge/pull/3480)
-   [@&#8203;Dogdriip](https://github.com/Dogdriip) made their first contribution in [https://github.com/electron/forge/pull/3482](https://github.com/electron/forge/pull/3482)

**Full Changelog**: electron/forge@v7.2.0...v7.3.0

</details>

<details>
<summary>napi-rs/napi-rs (@&#8203;napi-rs/cli)</summary>

### [`v3.0.0-alpha.41`](https://github.com/napi-rs/napi-rs/releases/tag/%40napi-rs/cli%403.0.0-alpha.41)

[Compare Source](https://github.com/napi-rs/napi-rs/compare/@napi-rs/cli@3.0.0-alpha.40...@napi-rs/cli@3.0.0-alpha.41)

##### What's Changed

-   fix(cli): fallback to wasm32 if platform is not support by [@&#8203;Brooooooklyn](https://github.com/Brooooooklyn) in [https://github.com/napi-rs/napi-rs/pull/1967](https://github.com/napi-rs/napi-rs/pull/1967)
-   fix(cli): allow more platform & arch fallback to wasm by [@&#8203;Brooooooklyn](https://github.com/Brooooooklyn) in [https://github.com/napi-rs/napi-rs/pull/1969](https://github.com/napi-rs/napi-rs/pull/1969)

**Full Changelog**: https://github.com/napi-rs/napi-rs/compare/napi@2.15.3...[@&#8203;napi-rs/cli](https://github.com/napi-rs/cli)[@&#8203;3](https://github.com/3).0.0-alpha.41

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/toeverything/AFFiNE).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIwMC4wIiwidGFyZ2V0QnJhbmNoIjoiY2FuYXJ5In0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants