Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): add missing peer dependencies #3635

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rtritto
Copy link

@rtritto rtritto commented Jun 19, 2024

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Fix warnings:

➤ YN0002: │ @electron-forge/template-webpack-typescript@workspace:packages/template/webpack-typescript doesn't provide typescript (pd370b), requested by fork-ts-checker-webpack-plugin.
➤ YN0002: │ @electron-forge/template-webpack-typescript@workspace:packages/template/webpack-typescript doesn't provide webpack (p738c5), requested by fork-ts-checker-webpack-plugin.
➤ YN0002: │ electron-forge@workspace:. doesn't provide eslint-plugin-ava (pa3622), requested by @malept/eslint-config.

Changes

package.json Outdated
@@ -122,6 +122,7 @@
"cross-env": "^7.0.2",
"electron-installer-common": "^0.10.2",
"eslint": "^8.0.1",
"eslint-plugin-ava": "^12.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an error with @malept/eslint-config because we don't use Ava as a test runner for Forge.

Copy link
Author

@rtritto rtritto Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, in @malept/eslint-config, the eslint-plugin-ava peer dependency needs to became optional; I will open an issue.

Edit: I opened issue malept/eslint-config#107

@rtritto rtritto marked this pull request as ready for review August 29, 2024 20:30
@rtritto rtritto requested a review from a team as a code owner August 29, 2024 20:30
@rtritto
Copy link
Author

rtritto commented Aug 29, 2024

@erickzhao I removed eslint-plugin-ava from dev dependencies (in malept/eslint-config#107, it will be an optional peer dependency).
Please can you review for merge?

@rtritto rtritto requested a review from erickzhao August 29, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants