Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(publisher-s3): add keyResolver option to allow users to make their own S3 key path #482

Merged
merged 1 commit into from
Apr 17, 2018

Conversation

MarshallOfSound
Copy link
Member

Fixes #374

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Tests / Docs will come with v6 tests / docs. This is gonna be a long process 😄

Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm holding you to the docs/tests before 6.0.0 😛

@MarshallOfSound MarshallOfSound merged commit ffc52da into master Apr 17, 2018
@MarshallOfSound MarshallOfSound deleted the key-resolver branch April 17, 2018 02:01
@starkos starkos mentioned this pull request Jul 25, 2018
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants