Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(all): upgrade dependencies #558

Merged
merged 6 commits into from
Sep 8, 2018
Merged

chore(all): upgrade dependencies #558

merged 6 commits into from
Sep 8, 2018

Conversation

malept
Copy link
Member

@malept malept commented Aug 30, 2018

Summarize your changes:

  • express-ws (mostly upgrading ws)
  • fs-extra
  • inquirer
  • ora
  • pify (Node >= 6)
  • username (Node >= 6)
  • @types/electron-packager (in sync with the major Packager version)
  • A bunch more type definitions
  • nyc
  • sinon (5.x, 6.x)
  • ts-node
  • Typescript 3

@malept
Copy link
Member Author

malept commented Aug 31, 2018

@MarshallOfSound my Typescript skills are not strong enough to figure out how to deal with this tsc octokit change: https://travis-ci.org/electron-userland/electron-forge/jobs/422827163#L893-L896

@malept malept force-pushed the upgrade-dependencies-9 branch from a7b54fb to 1db9b19 Compare September 1, 2018 03:40
@malept
Copy link
Member Author

malept commented Sep 1, 2018

I'm trying again, sans the Typescript changes.

@malept malept force-pushed the upgrade-dependencies-9 branch from 4d97351 to 82dd587 Compare September 3, 2018 05:05
@malept malept changed the title [WIP] chore(all): upgrade dependencies chore(all): upgrade dependencies Sep 3, 2018
@malept
Copy link
Member Author

malept commented Sep 3, 2018

This should be good to go. The only failure is the snap maker, and that seems to be because of a failure in snapcraft.

@malept
Copy link
Member Author

malept commented Sep 6, 2018

I've verified that it's a bug in snapcraft that's since been fixed, and I'm just waiting on the package to be backported to Ubuntu 16.04.

@malept malept force-pushed the upgrade-dependencies-9 branch from 729dcd6 to 82dd587 Compare September 6, 2018 07:20
@malept malept force-pushed the upgrade-dependencies-9 branch from c45488e to fe7af95 Compare September 7, 2018 16:55
@malept
Copy link
Member Author

malept commented Sep 8, 2018

🎉 all tests are green

@malept malept merged commit ee61540 into master Sep 8, 2018
@malept malept deleted the upgrade-dependencies-9 branch September 8, 2018 17:36
dsanders11 pushed a commit that referenced this pull request Jan 14, 2023
chore: remove chokidar dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant