Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): resolve forge.config.js by default if it exists #569

Merged
merged 1 commit into from
Sep 10, 2018

Conversation

MarshallOfSound
Copy link
Member

We have this semi-standard of forge.config.js, this makes it so if you don't have a <package.json>.config.forge entry we default to looking for a forge.config.js file if it exists.

Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 modulo an accidental commit

@@ -11,7 +11,7 @@ const defaults = {
plugins: [],
};

describe('forge-config', () => {
describe.only('forge-config', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@MarshallOfSound MarshallOfSound merged commit 5431dfa into master Sep 10, 2018
@MarshallOfSound MarshallOfSound deleted the default-js-config branch September 10, 2018 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants