feat(publisher-bitbucket): initial publish publisher-bitbucket #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er-bitbucket ISSUES CLOSED: #487
| // TODO: Consider checking if the files already exist at the current version and abort if so? | ||
|
|
||
| await asyncOra(`Uploading result (${index + 1}/${makeResults.length})`, async () => { | ||
| // TODO: See if we can use this same API for bitbucket server, we could take in a `host` config if so |
lukebatchelor
commented
Sep 11, 2018
| "version": "6.0.0-beta.28", | ||
| "description": "Github publisher for Electron Forge", | ||
| "repository": "https://github.com/electron-userland/electron-forge", | ||
| "author": "Samuel Attard", |
There was a problem hiding this comment.
Can I chuck my name here? XD
lukebatchelor
force-pushed
the
lbatch/add-bitbucket-publisher
branch
from
0638f7f to
625eb95
Compare
|
Ugh. Think I just need to delete the test command |
malept
reviewed
Sep 11, 2018
| const encodedUserAndPass = Buffer.from(`${auth.username}:${auth.appPassword}`).toString('base64'); | ||
|
|
||
| if (!(hasRepositoryConfig && config.repository.owner && config.repository.name)) { | ||
| throw 'In order to publish to Bitbucket you must set the "repository.owner" and "repository.name" properties in your forge config. See the docs for more info'; // eslint-disable-line |
There was a problem hiding this comment.
I generally prefer to specify which eslint rule I'm ignoring here.
There was a problem hiding this comment.
I honestly couldn't tell you which it was, I copied it from the GitHub one, probably max-len.
I'll update both tomorrow.
| /** | ||
| * If true, will override an existing version of a published release (will throw an error otherwise). | ||
| */ | ||
| overrideExistingVersion?: boolean; |
There was a problem hiding this comment.
bitbucket downloads don't technically have versions so this could be confusing to people, how about overrideExistingFiles?: boolean
There was a problem hiding this comment.
I went with replaceExistingFiles in the end if that's cool.
lukebatchelor
force-pushed
the
lbatch/add-bitbucket-publisher
branch
2 times, most recently
from
d5e6fb1 to
73653e0
Compare
…ublisher-bitbucket
lukebatchelor
force-pushed
the
lbatch/add-bitbucket-publisher
branch
from
73653e0 to
858a7e2
Compare
MarshallOfSound
approved these changes
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #487