Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-webpack): add an option to export webpack compilation stats #639

Merged
merged 11 commits into from
Jan 23, 2020

Conversation

sirgallifrey
Copy link
Contributor

BREAKING CHANGE:
This Feat is opt-in, so probably there is no breaking changes.

ISSUES CLOSED: #591

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Added two new options for webpack plugin, one for the main process and one for the renderer process.
If they are set to true, a stats.json file will be created respecting the webpack.stats config.

BREAKING CHANGE:
This Feat is opt-in, so probably there is no breaking changes.

ISSUES CLOSED: electron#591
BREAKING CHANGE:
This Feat is opt-in, so probably there is no breaking changes.

ISSUES CLOSED: electron#591
@sirgallifrey
Copy link
Contributor Author

I tried to rebase my mistakes away and ended up with two commits anyway... :(
Do I rebase again and force push them?

@malept
Copy link
Member

malept commented Dec 7, 2018

Don't worry about it. On merge it will likely be squashed.

Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want a test for this but I don't know exactly what it looks like.

@sirgallifrey
Copy link
Contributor Author

I'll give a shot on some tests, but they will probably be integration or functional tests since the code looks tightly coupled.

@malept
Copy link
Member

malept commented Dec 7, 2018

I'd prefer a functional test over an integration test. The tests take a while to run as it is.

@sirgallifrey
Copy link
Contributor Author

Testing on this plugin is hard to reason about and will likely to get convoluted :(
Would you be open for some refactoring on this plugin to break its functionalities in smaller classes so we can make cleaner tests?

@malept
Copy link
Member

malept commented Jan 31, 2019

cc @MarshallOfSound as he wrote the webpack plugin

@malept malept reopened this Jan 23, 2020
@malept malept changed the title feat(plugin-webpack): add an option to export webpack compilation stats. feat(plugin-webpack): add an option to export webpack compilation stats Jan 23, 2020
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good enough for now.

We do need to figure out a good way to test the compile steps in general, at least.

Thanks for your patience!

@malept malept merged commit 7275f39 into electron:master Jan 23, 2020
dsanders11 pushed a commit that referenced this pull request Jan 14, 2023
* build: update Electron releases JSON

* build: update Electron releases JSON

Co-authored-by: Electron Bot <electron-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to export webpack compilation stats
2 participants