-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin-webpack): add an option to export webpack compilation stats #639
Conversation
BREAKING CHANGE: This Feat is opt-in, so probably there is no breaking changes. ISSUES CLOSED: electron#591
BREAKING CHANGE: This Feat is opt-in, so probably there is no breaking changes. ISSUES CLOSED: electron#591
I tried to rebase my mistakes away and ended up with two commits anyway... :( |
Don't worry about it. On merge it will likely be squashed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably want a test for this but I don't know exactly what it looks like.
I'll give a shot on some tests, but they will probably be integration or functional tests since the code looks tightly coupled. |
I'd prefer a functional test over an integration test. The tests take a while to run as it is. |
Testing on this plugin is hard to reason about and will likely to get convoluted :( |
cc @MarshallOfSound as he wrote the webpack plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good enough for now.
We do need to figure out a good way to test the compile steps in general, at least.
Thanks for your patience!
* build: update Electron releases JSON * build: update Electron releases JSON Co-authored-by: Electron Bot <electron-bot@users.noreply.github.com>
BREAKING CHANGE:
This Feat is opt-in, so probably there is no breaking changes.
ISSUES CLOSED: #591
Summarize your changes:
Added two new options for webpack plugin, one for the main process and one for the renderer process.
If they are set to true, a stats.json file will be created respecting the webpack.stats config.