-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple Importer from Forge 5.x to 6.x #653
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why Tidelift is failing. It may just need a commit to master to kickstart it. |
4 tasks
…sion Also refactor src/util/electron-version
malept
force-pushed
the
import-5.x-to-6.x
branch
from
January 8, 2019 16:35
3545b63
to
35077a9
Compare
Electron nightly support was added to this PR because I was already in |
MarshallOfSound
approved these changes
Jan 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems legit
😆 I need to pick a better |
3 tasks
This comment has been minimized.
This comment has been minimized.
dsanders11
pushed a commit
that referenced
this pull request
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
Adds support for changing
config.forge
if it doesn't point to a JS file. In the future we could possibly provideupdateForgeConfig
for those JS files.There was some refactoring involved - as a result,
getElectronVersion
has test coverage.In general, the feature was written in such a way that it should have complete unit test coverage from a LoC perspective.