Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple Importer from Forge 5.x to 6.x #653

Merged
merged 5 commits into from
Jan 9, 2019
Merged

Conversation

malept
Copy link
Member

@malept malept commented Jan 3, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Adds support for changing config.forge if it doesn't point to a JS file. In the future we could possibly provide updateForgeConfig for those JS files.

There was some refactoring involved - as a result, getElectronVersion has test coverage.

In general, the feature was written in such a way that it should have complete unit test coverage from a LoC perspective.

@malept malept requested a review from MarshallOfSound January 3, 2019 08:51
@malept malept mentioned this pull request Jan 3, 2019
22 tasks
@malept
Copy link
Member Author

malept commented Jan 3, 2019

Not sure why Tidelift is failing. It may just need a commit to master to kickstart it.

@malept malept force-pushed the import-5.x-to-6.x branch from 3545b63 to 35077a9 Compare January 8, 2019 16:35
@malept
Copy link
Member Author

malept commented Jan 8, 2019

Electron nightly support was added to this PR because I was already in readElectronVersion.

Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@malept
Copy link
Member Author

malept commented Jan 8, 2019

😆 I need to pick a better electron version in the tests

@malept malept merged commit 1709af0 into master Jan 9, 2019
@malept malept deleted the import-5.x-to-6.x branch January 9, 2019 06:36
@terrellt

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants