Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: abstract base classes should implement shared type interfaces #684

Merged
merged 2 commits into from
Feb 8, 2019

Conversation

malept
Copy link
Member

@malept malept commented Feb 5, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (not applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

When I was researching #683, I found it odd that the abstract Base classes didn't implement the interfaces that are in use in @electron-forge/core when executing the plugins. If this is some TypeScript pattern, let me know and I'll update the PR to just have the empty init() method.

Fixes #683.

@ghost
Copy link

ghost commented Feb 8, 2019

Can this be fastracked a bit? I can't upgrade to .32 without it, and that pulls in security fixes for versions of ws and decompress-zip. npm audit refers to them as "high"

Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is happy, TS looks good 👍

@MarshallOfSound MarshallOfSound merged commit d15a8cc into master Feb 8, 2019
@MarshallOfSound MarshallOfSound deleted the base-classes-implement-interfaces branch February 8, 2019 18:30
dsanders11 pushed a commit that referenced this pull request Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants