Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-webpack): allow port to be configurable #693

Merged
merged 2 commits into from
Feb 26, 2019

Conversation

malept
Copy link
Member

@malept malept commented Feb 13, 2019

Summarize your changes:

Allows the webpack plugin config entry port to override the default port number of 3000, as that is a common port for various other dev servers.

This should be added to the v6 docs if merged.

ISSUES CLOSED: #691

Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be part of the webpack plugin config as well? 🤔

@malept
Copy link
Member Author

malept commented Feb 13, 2019

Maybe this should be part of the webpack plugin config as well? 🤔

Yep, that works too. I'll fix.

@malept malept force-pushed the configurable-webpack-port branch from fc77d01 to 35a2e68 Compare February 13, 2019 07:40
@malept
Copy link
Member Author

malept commented Feb 13, 2019

Updated.

@MarshallOfSound MarshallOfSound merged commit 4da0230 into master Feb 26, 2019
@MarshallOfSound MarshallOfSound deleted the configurable-webpack-port branch February 26, 2019 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants