Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin-webpack): throw an error if webpack generates compilation errors when packaging #695

Merged
merged 1 commit into from
Feb 26, 2019
Merged

fix(plugin-webpack): throw an error if webpack generates compilation errors when packaging #695

merged 1 commit into from
Feb 26, 2019

Conversation

malept
Copy link
Member

@malept malept commented Feb 13, 2019 •
edited
Loading

Summarize your changes:

This should only throw an error on package, not start.

Reference: https://webpack.js.org/api/node/#error-handling

ISSUES CLOSED: #579

@MarshallOfSound MarshallOfSound merged commit 696b11d into master Feb 26, 2019
@MarshallOfSound MarshallOfSound deleted the error-out-when-webpack-gives-compilation-errors branch February 26, 2019 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malept @MarshallOfSound