Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): restart app in development via CLI multiple times #904

Merged
merged 3 commits into from
Jun 12, 2019
Merged

fix(core): restart app in development via CLI multiple times #904

merged 3 commits into from
Jun 12, 2019

Conversation

miaowing
Copy link

@miaowing miaowing commented Jun 2, 2019 •
edited
Loading

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Fixes: #903

@malept malept changed the title fix: typed rs not restart app after the first restarted fix(core): restart app in development via CLI multiple times Jun 12, 2019
malept
malept approved these changes Jun 12, 2019
View reviewed changes
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and it works. Thanks for your patience.

packages/api/core/src/api/start.ts Outdated Show resolved Hide resolved
@malept malept merged commit df98fe8 into electron:master Jun 12, 2019
dsanders11 pushed a commit that referenced this pull request Jan 14, 2023
@erickzhao
chore: release v0.27.0 (#904)
d02baea 
* build: add GITHUB_TOKEN to Make step
* build: separate `yarn make` jobs per arch
* v0.27.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malept malept malept approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typed rs to restart app, only available at the first?
2 participants
@miaowing @malept