Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add LICENSE #172

Merged
merged 3 commits into from
Oct 14, 2020
Merged

chore: add LICENSE #172

merged 3 commits into from
Oct 14, 2020

Conversation

erickzhao
Copy link
Member

ref #164

Adds a LICENSE file to reflect the license indicated in package.json.

@erickzhao erickzhao requested review from malept and a team October 14, 2020 15:56
@erickzhao erickzhao marked this pull request as draft October 14, 2020 16:04
@ckerr
Copy link
Member

ckerr commented Oct 14, 2020

Wheee, relicensing!

The only license that makes sense is the same one used for all the other Electron projects, so I imagine making that licensing explicit will be as simple as getting a 👍 from the authors.

I see this is marked as a WIP, but when this is ready for broader consumption it would make sense to flag not just Mark and Sam, but also Max, Kevin, Selwyn, et al to get affirmation.

Edit: my mistake, I didn't notice that MIT was already listed in package.json. This PR seems to just be making it more explicit than before, not relicensing.

@erickzhao erickzhao marked this pull request as ready for review October 14, 2020 16:52
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, otherwise LGTM

LICENSE Outdated Show resolved Hide resolved
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
@erickzhao erickzhao merged commit de10db6 into master Oct 14, 2020
@vhashimotoo vhashimotoo deleted the add-license-1 branch October 14, 2020 17:09
@electron-bot
Copy link
Contributor

🎉 This PR is included in version 1.12.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants