Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update dependencies to clean up yarn audit #234

Merged
merged 6 commits into from
Oct 31, 2023
Merged

fix: update dependencies to clean up yarn audit #234

merged 6 commits into from
Oct 31, 2023

Conversation

MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Dec 1, 2022 •
edited
Loading

BREAKING CHANGE: The minimum supported node version is now node 14

This PR also as a side effect ensures tests can pass / run on M1 hardware.

@MarshallOfSound MarshallOfSound requested a review from a team December 1, 2022 23:34
@BlackHole1
Copy link
Member

CI failed. Reason: error @continuous-auth/semantic-release-npm@3.0.0: The engine "node" is incompatible with this module. Expected version ">=16 || ^14.17". Got "12.13.1".

Restoration Solutions:

  1. Use --ignore-engines In CI. Since only devDependencies are upgraded, it does not affect the end-users.
  2. Fallback @continuous-auth/semantic-release-npm version
  3. Modifdy https://github.com/electron/get/blob/main/package.json#L26 to >=16

@BlackHole1
Copy link
Member

CI failed again.
image

Optional Chaining was not implemented until after nodejs version 14

MarshallOfSound and others added 2 commits October 30, 2023 23:29
@MarshallOfSound MarshallOfSound changed the title build: update dependencies to clean up yarn audit fix: update dependencies to clean up yarn audit Oct 31, 2023
BlackHole1
BlackHole1 previously requested changes Oct 31, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@MarshallOfSound @BlackHole1
Update package.json
f113153 
Co-authored-by: Black-Hole <158blackhole@gmail.com>
@MarshallOfSound MarshallOfSound merged commit 6ab6b88 into main Oct 31, 2023
3 checks passed
@continuous-auth Continuous Auth
Copy link

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Dramaga11 Dramaga11 mentioned this pull request Jun 3, 2024
Merged
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 19, 2024
Open
@sedwin928 sedwin928 mentioned this pull request Jul 26, 2024
Open
@sedwin928 sedwin928 mentioned this pull request Aug 6, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Aug 12, 2024
Open
This was referenced Aug 29, 2024
Open
Open
This was referenced Sep 8, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsanders11 dsanders11 dsanders11 approved these changes

@erickzhao erickzhao erickzhao approved these changes

@BlackHole1 BlackHole1 BlackHole1 left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarshallOfSound @BlackHole1 @dsanders11 @erickzhao