Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron 14.1.1 return abi version 89 when its really 97 #113

Closed
Zvicii opened this issue Oct 20, 2021 · 2 comments
Closed

electron 14.1.1 return abi version 89 when its really 97 #113

Zvicii opened this issue Oct 20, 2021 · 2 comments
Labels
released

Comments

@Zvicii
Copy link

Zvicii commented Oct 20, 2021

run thie under node v16.6.1 windows 10
console.info(14.1.1 ${nodeAbi.getAbi('14.1.1', 'electron')})

I get
14.1.1 89

image
@Zvicii
Copy link
Author

Zvicii commented Oct 20, 2021

maybe its electron-releases typo, since the node version is the same.

@electron-bot
Copy link

🎉 This issue has been resolved in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@csett86 csett86 mentioned this issue Nov 7, 2021
Merged
vweevers pushed a commit to prebuild/prebuild-install that referenced this issue Nov 12, 2021
@csett86
Breaking: bump node-abi so that Electron 14+ gets correct ABI (#161)
477f347 
electron/node-abi#113 was fixed in 3.3.0
and is affecting Electron 14+.

With the current node-abi prebuild-install will download ABI 89 for
electron 14 and 15 and then modules will fail to load as electron 14
has ABI 97 and electon 15 has ABI 98 in reality.

Drops support of Node.js < 10.
@zixuan945 zixuan945 mentioned this issue Nov 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@electron-bot @Zvicii