This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix: export napi symbols #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matches the change in node.h in 88b4941, both are necessary because Chromium builds with symbols hidden by default
addaleax
approved these changes
Oct 15, 2018
addaleax
reviewed
Oct 15, 2018
src/node_api.h
Outdated
| @@ -31,7 +31,7 @@ struct uv_loop_s; // Forward declaration. | |||
| #define NAPI_EXTERN __declspec(dllexport) | |||
| #endif | |||
| #else | |||
| #define NAPI_EXTERN /* nothing */ | |||
| #define NAPI_EXTERN __attribute((visibility("default"))) | |||
There was a problem hiding this comment.
Not sure whether it matters to you, but the node.h patch uses __attribute__, as does most of Node.js by itself (e.g. this would probably requested when upstreaming the change.)
There was a problem hiding this comment.
d'oh, this was just a typo. fixed :) good catch!
MarshallOfSound
approved these changes
Oct 15, 2018
nornagon
added a commit
to electron/electron
that referenced
this pull request
Oct 15, 2018
brings in electron/node#76 and electron/node#77
2 tasks
nornagon
added a commit
that referenced
this pull request
Oct 16, 2018
matches the change in node.h in 88b4941, both are necessary because Chromium builds with symbols hidden by default
trop-bot
pushed a commit
to trop-bot/electron
that referenced
this pull request
Oct 18, 2018
brings in electron/node#76 and electron/node#77
MarshallOfSound
pushed a commit
to electron/electron
that referenced
this pull request
Oct 18, 2018
* chore: roll node brings in electron/node#76 and electron/node#77 * chore: roll node
trop-bot
pushed a commit
to trop-bot/electron
that referenced
this pull request
Oct 18, 2018
brings in electron/node#76 and electron/node#77
codebytere
pushed a commit
to electron/electron
that referenced
this pull request
Oct 19, 2018
* chore: roll node brings in electron/node#76 and electron/node#77 * chore: roll node
MarshallOfSound
pushed a commit
that referenced
this pull request
Oct 25, 2018
matches the change in node.h in 88b4941, both are necessary because Chromium builds with symbols hidden by default
MarshallOfSound
pushed a commit
that referenced
this pull request
Oct 25, 2018
matches the change in node.h in 88b4941, both are necessary because Chromium builds with symbols hidden by default
deepak1556
pushed a commit
that referenced
this pull request
Dec 10, 2018
matches the change in node.h in 88b4941, both are necessary because Chromium builds with symbols hidden by default
deepak1556
pushed a commit
that referenced
this pull request
Dec 11, 2018
matches the change in node.h in 88b4941, both are necessary because Chromium builds with symbols hidden by default
deepak1556
pushed a commit
that referenced
this pull request
Dec 19, 2018
matches the change in node.h in 88b4941, both are necessary because Chromium builds with symbols hidden by default
deepak1556
pushed a commit
that referenced
this pull request
Dec 19, 2018
matches the change in node.h in 88b4941, both are necessary because Chromium builds with symbols hidden by default
deepak1556
pushed a commit
that referenced
this pull request
Dec 19, 2018
matches the change in node.h in 88b4941, both are necessary because Chromium builds with symbols hidden by default
deepak1556
pushed a commit
that referenced
this pull request
Dec 25, 2018
matches the change in node.h in 88b4941, both are necessary because Chromium builds with symbols hidden by default
nitsakh
pushed a commit
that referenced
this pull request
Mar 18, 2019
matches the change in node.h in 88b4941, both are necessary because Chromium builds with symbols hidden by default
nitsakh
pushed a commit
that referenced
this pull request
Mar 18, 2019
matches the change in node.h in 88b4941, both are necessary because Chromium builds with symbols hidden by default
nitsakh
pushed a commit
that referenced
this pull request
Mar 18, 2019
matches the change in node.h in 88b4941, both are necessary because Chromium builds with symbols hidden by default
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matches the change in node.h in 88b4941, both are necessary because Chromium builds with symbols hidden by default
Fixes electron/electron#15168