Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove node 10 job #1403

Merged
merged 1 commit into from
Aug 22, 2022
Merged

chore: remove node 10 job #1403

merged 1 commit into from
Aug 22, 2022

Conversation

VerteDinde
Copy link
Member

@VerteDinde VerteDinde commented Aug 22, 2022

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

CI is failing on Node 10 because multiple packages no longer support it (fs-extra, get, etc).
This PR eliminates that job so we can do a stable release. After which, we'll move to Node 14 as a minimum version number.

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #1403 (750aaab) into main (7c01d6f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1403   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files          15       15           
  Lines         776      776           
=======================================
  Hits          742      742           
  Misses         34       34           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@VerteDinde VerteDinde merged commit 1baed70 into main Aug 22, 2022
@VerteDinde VerteDinde deleted the remove-node-10 branch August 22, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant