Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump electronjs/node to 2.1.0 (main) #1112

Merged
merged 3 commits into from
Nov 21, 2023
Merged

chore: bump electronjs/node to 2.1.0 (main) #1112

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d79e8ca
chore: bump electronjs/node in .circleci/config.yml to 2.1.0
electron-roller[bot] Nov 17, 2023
a70fdcf
ci: node < 14 fixes
dsanders11 Nov 18, 2023
f7cd7e6
ci: fixes
dsanders11 Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 23 additions & 11 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@ version: 2.1

orbs:
cfa: continuousauth/npm@2.1.0
node: electronjs/node@1.2.0
node: electronjs/node@2.1.0

executors:
windows:
environment:
GYP_MSVS_VERSION: '2022'
machine:
image: windows-server-2022-gui:stable
image: windows-server-2022-gui:current
resource_class: windows.medium
shell: bash.exe

Expand All @@ -21,6 +21,17 @@ workflows:
name: test-<< matrix.executor >>-<< matrix.node-version >>
pre-steps:
- run: git config --global core.autocrlf input
- when:
condition:
or:
- and:
- equal: [ node/macos, << matrix.executor >> ]
- equal: [ '14.16', << matrix.node-version >> ]
- and:
- equal: [ node/macos, << matrix.executor >> ]
- equal: [ '12.22', << matrix.node-version >> ]
steps:
- node/install-rosetta
- when:
condition:
equal: [ windows, << matrix.executor >> ]
Expand All @@ -33,8 +44,8 @@ workflows:
- when:
condition:
or:
- equal: [ 14.21.3, << matrix.node-version >> ]
- equal: [ 12.22.12, << matrix.node-version >> ]
- equal: [ '14.16', << matrix.node-version >> ]
- equal: [ '12.22', << matrix.node-version >> ]
steps:
# Update npm so it works with latest Python 3
- run: npm install -g npm@8
Expand All @@ -54,16 +65,17 @@ workflows:
- node/macos
- windows
node-version:
- 20.2.0
- 18.16.0
- 16.20.0
- 14.21.3
- 12.22.12
- '20.9'
- '18.17'
- '16.20'
# Stay below 14.17.0 or nvm tries to download arm64 artifacts which don't exist
- '14.16'
- '12.22'
exclude:
- executor: windows
node-version: 14.21.3
node-version: '14.16'
- executor: windows
node-version: 12.22.12
node-version: '12.22'
- cfa/release:
requires:
- test
Expand Down