Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: download arm64 clang when using Electron clang on Apple Silicon #1113

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

dsanders11
Copy link
Member

Switching to M1 runners on CircleCI pointed out this issue.

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (dc7b7f3) 76.30% compared to head (3079660) 75.44%.

Files Patch % Lines
src/clang-fetcher.ts 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1113      +/-   ##
==========================================
- Coverage   76.30%   75.44%   -0.87%     
==========================================
  Files          21       21              
  Lines         726      729       +3     
  Branches      136      137       +1     
==========================================
- Hits          554      550       -4     
- Misses        121      125       +4     
- Partials       51       54       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsanders11 dsanders11 force-pushed the fix-apple-silicon-clang branch from d9e4e94 to 3079660 Compare November 21, 2023 22:37
@dsanders11 dsanders11 marked this pull request as ready for review November 21, 2023 22:56
@dsanders11 dsanders11 requested a review from a team as a code owner November 21, 2023 22:56
@dsanders11 dsanders11 merged commit 25bcc0d into main Nov 21, 2023
3 checks passed
@dsanders11 dsanders11 deleted the fix-apple-silicon-clang branch November 21, 2023 23:14
Copy link

🎉 This PR is included in version 3.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants