fix: ensure Electron.Utility property exists

[devm33]

Added in #246, the Utility namespace currently has no concrete values in it on electron/electron@main. This change ensures Electron.Utility is available as a property even when the namespace has no values.

Takes advantage of declaration merging: https://www.typescriptlang.org/docs/handbook/declaration-merging.html

Other approaches considered:

• Separating out the values from each namespace into interfaces and setting properties for each interface.
  • Decided this was too invasive for questionable value
• Adding a dummy value to the Utility namespace to ensure it's never empty.
  • Decided too much of a hack and dummy value would be visible to end users

Tested with node spec/ts-smoke/runner.js on electron/electron@main

Should unblock electron/electron#40264 to ultimately be used (and made not empty) in electron/electron#40017

[dsanders11]

Should that line be guarded with a check that UtilityNamespace.length > 2? Doing a quick test I'm not sure declaration merging works in this situation since one is a namespace and the other is a value. It doesn't error if the namespace is empty, but if I put anything in the namespace, I see error TS2300: Duplicate identifier 'Utility'.

[devm33]

Should that line be guarded with a check that UtilityNamespace.length > 2? Doing a quick test I'm not sure declaration merging works in this situation since one is a namespace and the other is a value. It doesn't error if the namespace is empty, but if I put anything in the namespace, I see error TS2300: Duplicate identifier 'Utility'.

Ah thanks for checking that. I see the declaration merging only works when the namespace doesn't have any values because otherwise it's trying to merge two variables.

Added a check to only set the property if the Utility namespace doesn't have any values: 3091893

[devm33]

@MarshallOfSound friendly bump when you're able to review 🙏

[dsanders11]

@devm33, we're good to go here, just a merge conflict due to #249 being merged. Once you resolve that I'll merge this. 👍

[devm33]

@devm33, we're good to go here, just a merge conflict due to #249 being merged. Once you resolve that I'll merge this. 👍

Awesome, thanks @dsanders11! Conflict resolved.

Once merged and published, I'll update electron/electron#40264

[continuous-auth]

🎉 This PR is included in version 8.15.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀