Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: convert website to TypeScript #330

Merged
merged 19 commits into from
Jan 16, 2023
Merged

refactor: convert website to TypeScript #330

merged 19 commits into from
Jan 16, 2023

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Dec 1, 2022

This pull request rewrites our website in TypeScript, which added first-class support in Docusaurus 2 sometime after we first bootstrapped this project.

The biggest change is that docusaurus.config.js becomes a thin shell for docusaurusConfig.ts, since Docusaurus doesn't support first-class TypeScript configuration yet (facebook/docusaurus#7911 (comment)).

@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-330 December 13, 2022 02:30 Inactive
@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-330 December 13, 2022 06:52 Inactive
@erickzhao erickzhao changed the title build: convert website to TypeScript refactor: convert website to TypeScript Dec 13, 2022
@erickzhao erickzhao marked this pull request as ready for review December 13, 2022 21:14
@erickzhao erickzhao requested a review from a team December 13, 2022 21:28
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. TIL about the TS satisfies keyword. A couple of nit inline comments.

src/pages/home/_components/AppsGrid.tsx Outdated Show resolved Hide resolved
src/plugins/apps/index.ts Outdated Show resolved Hide resolved
@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-330 December 14, 2022 21:15 Inactive
@erickzhao
Copy link
Member Author

gonna need to set up linting for typescript lol cuz we don't have js files in src/ anymore

@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-330 December 16, 2022 23:37 Inactive
@erickzhao
Copy link
Member Author

from there, looks like the tests need updating as well.

@dsanders11
Copy link
Member

If this is still in-progress, can you make it a draft until it's ready for final review? That way it's more clear when that point is reached.

@erickzhao erickzhao marked this pull request as draft December 18, 2022 02:47
@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-330 January 13, 2023 00:50 Inactive
@erickzhao erickzhao marked this pull request as ready for review January 13, 2023 00:56
@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-330 January 13, 2023 00:57 Inactive
@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-330 January 16, 2023 19:15 Inactive
@erickzhao erickzhao merged commit 965262d into main Jan 16, 2023
@erickzhao erickzhao deleted the ts branch January 16, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants