Membre (coté Admin) : petits refactoring (template pour status_icon, cacher beneficiary_count si pas pertinent) #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
force-pushed
the
raphodn/member-status-icons-template
branch
from
d643a7b
to
78b714d
Compare
raphodn
commented
Oct 27, 2023
|
|
||
| public function __construct(ContainerInterface $container, $use_fly_and_fixed) | ||
| public function __construct(ContainerInterface $container) |
There was a problem hiding this comment.
@samueleyre est-ce que c'est une bonne pratique de récupérer les paramètres via le container plutôt que via le services.yml + construct ? Ca clean le code en tout cas je trouve !
There was a problem hiding this comment.
De ce que j'ai lu sur le sujet, ce n'est pas trop recommandé pour cette version de symfony, mais je trouve aussi que c'est plus clair.
En symfony 4.1, on peut utiliser le "ParameterBagInterface" pour avoir accès aux paramètres donc je pense que c'est pas une mauvaise chose de ne pas avoir à spécifier tous les paramètres utiles dans service.yml.
OursDesCavernes
pushed a commit
to Les400Coop/gestion-compte
that referenced
this pull request
Jan 20, 2024
…cacher beneficiary_count si pas pertinent) (elefan-grenoble#1053) * Member: move status icons to own template * Member search: hide beneficiary_count if maximum_nb_of_beneficiaries_in_membership=1 * simplify BeneficiaryCanHostValidator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications apportées :
_partial/status_icons.html.twigpour factoriser le code (apparaissait à 3 endroits)beneficiary_countseulement si le paramètremaximum_nb_of_beneficiaries_in_membershipest supérieur à 1