SwipeCardLog : pouvoir les rattacher à SwipeCard #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
force-pushed
the
raphodn/swipe-card-revert-join
branch
from
69ee1a7
to
167973d
Compare
petitalb
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Il y a 2 ans, un premier commit (2f47a5b) avait rajouté la table
SwipeCardLogpour avoir un historique de chaque passage de badge. Cet historique était rattaché au badge, donc non anonyme.Un deuxième commit (5026ee2) à remplacé le lien vers le badge par un
counter, et ainsi rendu cet historique anonyme. C'était une demande au sein de l'Elefan à l'époque.La politique au sein de l'Elefan n'a pas changé, mais cette PR permet à la coop de choisir : anonyme ou rattaché au badge.
Un nouveau paramètre
swipe_card_logging_anonymousa été rajouté