Refactor booking shift admin #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
petitalb
commented
Oct 31, 2022
petitalb
commented
- Remove n+1 queries to speedup listing shift (making joins with 'formation' table)
- Remove 'POST' ajax calls to book shifts
- Refactor 'admin_shift_book' endpoint to use symfony form
- Use ajax to load buckets in admin shift booking modals (to avoid loading all buckets)
raphodn
reviewed
Nov 2, 2022
raphodn
approved these changes
Nov 2, 2022
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| <div data-offset="{{ (((bucket.start|date('G')-start)*60 + bucket.start|date('i'))/60) }}" data-length="{{ (100/(end-start+1)) }}" | |||
| style="padding: 0 1px;width:{{ (bucket.duration / 60) * (100/(end-start+1)) }}%;position: absolute;left:{{ (((bucket.start|date('G')-start)*60 + bucket.start|date('i'))/60)*(100/(end-start+1)) }}%;top: {{ line*10 }}px;"> | |||
| <a href="#edit{{ bucket.first.id }}" class="modal-trigger tooltipped" data-position="top" data-delay="100" data-tooltip="{{ bucket.first.job.name }}"> | |||
| <a href="#modal-bucket" data-source="{{ path('shift_show', { 'id': bucket.first.id }) }}" class="modal-trigger tooltipped" data-position="top" data-delay="100" data-tooltip="{{ bucket.first.job.name }}"> | |||
- Remove n+1 queries to speedup listing shift (making joins with 'formation' table) - Remove 'POST' ajax calls to book shifts - Refactor 'admin_shift_book' endpoint to use symfony form - Use ajax to load buckets in admin shift booking modals (to avoid loading all buckets)
petitalb
force-pushed
the
feature/use-ajax-to-load-modals
branch
from
481d725
to
bc182b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.