Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug dans ShiftService #665

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Bug dans ShiftService #665

merged 2 commits into from
Dec 2, 2022

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented Dec 2, 2022

ShiftService > canBookDuration > undefined variable $membership

@@ -131,7 +131,7 @@ public function canBookDuration(Beneficiary $beneficiary, $duration, $cycle = 0)

$member = $beneficiary->getMembership();
$beneficiary_counter = $this->beneficiaryService->getTimeCount($beneficiary, $cycle);
$cycle_end = $this->membershipService->getEndOfCycle($membership, $cycle);
$cycle_end = $this->membershipService->getEndOfCycle($member, $cycle);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

la typo en question

@raphodn raphodn requested a review from petitalb December 2, 2022 10:51
@raphodn raphodn self-assigned this Dec 2, 2022
@raphodn raphodn merged commit 2a212c1 into master Dec 2, 2022
@raphodn raphodn deleted the raphodn/shift-service-fix branch December 2, 2022 15:28
quot17 pushed a commit to quot17/gestion-compte that referenced this pull request Mar 28, 2023
* Fix undefined variable 'membership'

* add config in ShiftService
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants