Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeLog : nouveau champ requestRoute #730

Merged
merged 6 commits into from
Feb 1, 2023

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented Jan 31, 2023

Quoi ?

dans le modèle TimeLog

  • nouveau champ requestRoute (similaire à ShiftFreeLog)

dans le service TimeLogService

  • s'inspirer de ShiftFreeLogService (importer RequestStack, TokenStorage)
  • stocker par défaut le createdBy & requestRoute
  • nouvelle fonction initTimeLog
  • renommer les autres fonctions pour bien indiquer "TimeLog" dans leur suffix

dans Admin > Membres :

  • dans le tableau "Compteur temps", nouvelle colonne "Route"

@raphodn raphodn self-assigned this Jan 31, 2023
@raphodn raphodn requested a review from petitalb January 31, 2023 09:28
@raphodn raphodn marked this pull request as ready for review January 31, 2023 14:29
@raphodn raphodn force-pushed the raphodn/time-log-createdby-requestroute branch from 5fbd35c to fb1ff56 Compare January 31, 2023 15:43
$log->setType(TimeLog::TYPE_SHIFT);
$log->setShift($shift);
$log->setTime($shift->getDuration());

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ne pourrait-on pas ici mettre aussi la route (i.e., savoir si le créneau a été validé par la badgeuse ou manuellement. Si manuel, on pourrait aussi logguer qui a fait l'action ?)

Copy link
Member Author

@raphodn raphodn Feb 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est déjà fait via l'appel à initTimeLog 😉

@raphodn raphodn merged commit 352be1c into master Feb 1, 2023
@raphodn raphodn deleted the raphodn/time-log-createdby-requestroute branch February 1, 2023 12:35
raphodn added a commit that referenced this pull request Feb 1, 2023
quot17 pushed a commit to quot17/gestion-compte that referenced this pull request Mar 28, 2023
* Add TimeLog.requestRoute field

* Add new TimeLogService.initTimeLog. set createdBy & requestRoute

* Display TimeLog.requestRoute in the template
quot17 pushed a commit to quot17/gestion-compte that referenced this pull request Mar 28, 2023
quot17 pushed a commit to quot17/gestion-compte that referenced this pull request Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lors d'actions sur les créneaux passés, ne pas supprimer les TimeLog correspondants
2 participants