Roles : restreindre la suppression de créneaux (et de bucket) aux ADMIN #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petitalb
reviewed
Feb 23, 2023
| </button> | ||
| {{ form_end(shift_delete_forms[shift.id]) }} | ||
| {% if is_granted("ROLE_ADMIN") %} | ||
| {% if not shift.lastShifter %} |
There was a problem hiding this comment.
Pourquoi ne pas concatener les if ensemble ?
There was a problem hiding this comment.
pour bien séparer la section "ADMIN" de "non-ADMIN"
dans ce cas là il y a qu'un seul bouton, mais on pourrait imaginer que cette section soit plus grande
je trouve ça plus clair :)
petitalb
approved these changes
Feb 23, 2023
quot17
pushed a commit
to quot17/gestion-compte
that referenced
this pull request
Mar 28, 2023
…IN (elefan-grenoble#765) * Only ADMIN can delete shift. add ShiftDeletedEvent * Only ADMIN can delete bucket. Rename bucket_add_form
OursDesCavernes
pushed a commit
to Les400Coop/gestion-compte
that referenced
this pull request
Jan 20, 2024
…IN (elefan-grenoble#765) * Only ADMIN can delete shift. add ShiftDeletedEvent * Only ADMIN can delete bucket. Rename bucket_add_form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoi ?
Restreindre les routes
shift_deleteetbucket_deleteaux ROLE_ADMINPourquoi ?